Load cover art more efficiently #802
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
If i wanted to continue on this, should i fork your cover-cache branch? |
Contributor
@teamcons I don't know if it is considered the "best" practice but I would fork their branch, add your fixes, and do a PR to merge your change into their branch. If they does not respond after a bit then I guess make a new PR here and we can say it replaces this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Music loads the cover art for every single song added to the queue into memory, no matter if the same cover art was already used by other songs. When opening multiple albums at once this can quickly lead to a lot of memory being wasted.
So I implemented a simple cover cache that makes sure that each individual cover only gets loaded into memory once and is then reused by songs from the same album.
This is still WIP. Just putting it here to avoid that someone else unnecessarily starts working on the same thing.